Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing wrong local path detection with 'paket install' #773

Merged
merged 6 commits into from
Apr 14, 2015

Conversation

Stift
Copy link
Contributor

@Stift Stift commented Apr 13, 2015

Assume you have the following setup.
A Nuget source Externals\NugetStore (i.e. in your repo a local folder is used for some nuget packages) and you start e.g. your paket install in any subdirectory (e.g. Externals). Paket discovers correctly the paket.dependencies file. But it then fails to detect the folder correctly because it tries to combine the relative folder from your start directory (and it tries to look for Externals\Externals\NugetStore) and not in relative to the location paket.dependencies file.
Other paket commands never had any problems with that.

@forki
Copy link
Member

forki commented Apr 13, 2015

It's failing on TravisCI. Is that related?

@Stift
Copy link
Contributor Author

Stift commented Apr 13, 2015

it's linux/windows related. I have to adapt some unit tests.

@Stift
Copy link
Contributor Author

Stift commented Apr 13, 2015

Ok. The Travis build is fine now. Should I also update the documentation? This is not clearly saying that relative pathes are also allowed. I just tried it out and it worked.

@forki
Copy link
Member

forki commented Apr 13, 2015

Yes. Please update the docs.
On Apr 13, 2015 10:58 PM, "Christian" [email protected] wrote:

Ok. The Travis build is fine now. Should I also update the documentation?
This is not clearly saying that relative pathes are also allowed. I just
tried it out and it worked.


Reply to this email directly or view it on GitHub
#773 (comment).

@Stift
Copy link
Contributor Author

Stift commented Apr 13, 2015

From my side everything seems to be okay.

@forki
Copy link
Member

forki commented Apr 13, 2015

Cool. Will look at it tomorrow. Thanks a lot.
On Apr 13, 2015 23:16, "Christian" [email protected] wrote:

From my side everything seems to be okay.


Reply to this email directly or view it on GitHub
#773 (comment).

forki added a commit that referenced this pull request Apr 14, 2015
Fixing wrong local path detection with 'paket install'
@forki forki merged commit da29e78 into fsprojects:master Apr 14, 2015
@Stift Stift deleted the LocalRelativePathDetection branch April 14, 2015 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants